Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(conformance): validate implementation flags #3715

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(conformance): validate implementation flags #3715

wants to merge 2 commits into from

Conversation

mlavacca
Copy link
Member

@mlavacca mlavacca commented Mar 27, 2025 •
edited
Loading

What type of PR is this?

/area conformance-machinery

What this PR does / why we need it:

The conformance suite implementation-related flags are properly validated.

Which issue(s) this PR fixes:

Fixes #2178

Does this PR introduce a user-facing change?:

The conformance suite implementation-related flags are properly validated.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/conformance-machinery Issues or PRs related to the machinery and the suite used to run conformance tests. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 27, 2025
@mlavacca
Copy link
Member Author

/retest

@youngnick
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 27, 2025
@mlavacca
Copy link
Member Author

/retest

mlavacca added 2 commits March 28, 2025 10:10
@mlavacca
feat(conformance): validate implementation flags
3472900 
Signed-off-by: Mattia Lavacca <[email protected]>
@mlavacca
chore: gofumpt
d6a4019 
Signed-off-by: Mattia Lavacca <[email protected]>
@mlavacca mlavacca force-pushed the validate-conf-suite-flags branch from 0f34cff to d6a4019 Compare March 28, 2025 09:11
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 28, 2025
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mlavacca

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mlavacca
Copy link
Member Author

mlavacca commented Apr 3, 2025

@youngnick I lost your lgtm as I needed to lint the code. Do you mind taking another look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howardjohn howardjohn Awaiting requested review from howardjohn

@mikemorris mikemorris Awaiting requested review from mikemorris

Assignees

@youngnick youngnick

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance-machinery Issues or PRs related to the machinery and the suite used to run conformance tests. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validate conformance profiles suite flag values
3 participants
@mlavacca @youngnick @k8s-ci-robot